On 8 June 2015 at 15:17, Alex Lemberg <Alex.Lemberg@xxxxxxxxxxx> wrote: > Hi Ulf, > > [...] > >> >> One of my comments for v2, was that I think you should remove all code which >> was related to HPI to interrupt sleep notification from the runtime PM resume >> path. Instead I wanted you to add that functionality as separate patch based on >> top of this patch. >> >> You haven't done that in v3, why? > > The sleep_notify call was moved to suspend() per your recommendation. > As far as I understand, no new requests should be sent during mmc_suspend() process, > thus HPI support is not needed anymore. > Is this the correct assumption? Yes. I don't think you need mmc_card_set_sleep_notify() and the corresponding new MMC_STATE_SLEEP_NOTIFY , mmc_device_prg_state(), etc. Overall, I think this patch could be simplified yet another step. > The only case where HPI is used in this patch - is during sleep_notify timeout error. Why? One final question, I noticed that you have removed the check for MMC_CAP2_FULL_PWR_CYCLE in the _mmc_suspend() function, why? Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
