Hi Arnd, Ulf Thank you for your feedback > > Then, I want to try "dmaengine cleanup" patch-set as 2nd step if possible. > > I guess [8/9] and [9/9] are not good for "header cleanup" (?) I don't know. > > Arnd, Ulf, what is your opinion ? > > Patch 8 looks great to me. > > Patch 9 as I mentioned is a bit strange because it duplicates the some > of the data between tmio_mmc_data and tmio_mmc_dma, which are both > visible to the tmio_mmc_dma.c file. Simply folding tmio_mmc_dma into > tmio_mmc_data seems like the simplest solution to that. OK, I see. I will fixup 9/9. Ulf Can you please care about 1/9 - 8/9 as 1st step ? (I got review from Geert about 8/9, so, 1/9 - 7/9 ?) I will re-try about 9/9 (or 8/9, 9/9) part. And, then, I will try dmaengine cleanup. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
