Re: [PATCH] mmc: davinci_mmc: add warnings for edma failures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Uffe,

many hanks for the reply,

>> Add warnings in case the edma engine driver fails to allocate slots or
>> channels requested from the davinci_mmc driver.
>>
>> Some ti-davinci based boards (i.e. board-da850-evm.c) are asking for
>> some reserved chans / slots at board init stage. Later, the mmc driver
>> results in a silent locked state.
>
> So why does davinci_acquire_dma_channels() succeed then? Isn't that
> real problem you should be looking into?

i explain with more details,

my custom am1808 board initialization, based on arch/arm/mach-davinci/board-da850-evm.c, reserves some dma chans / slots for the audio at
early boot.

While on kernel 3.5.1 mmc was working properly, moving to kernel
3.17.0, due to the dma-engine wrapper introduction (to be selected
into menuconfig), the mmc host driver locks silently. System cannot
even "reboot" after the failed attempt to reserve the dma slots.

I hardly found out the reason due to missing of clear warnings.

So there is nothing to fix in any other place. Simply, i am suggesting
a more visible warning so the driver, instead of lock-up silently,
throws a problem.

Feel free to add or discard the patch, as you can see it is nothing functional.

Regards,
Angelo



--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux