On 22 November 2014 at 01:00, Angelo Dureghello <angelo@xxxxxxxx> wrote:
> Add warnings in case the edma engine driver fails to allocate slots or
> channels requested from the davinci_mmc driver.
>
> Some ti-davinci based boards (i.e. board-da850-evm.c) are asking for
> some reserved chans / slots at board init stage. Later, the mmc driver
> results in a silent locked state.
So why does davinci_acquire_dma_channels() succeed then? Isn't that
real problem you should be looking into?
Kind regards
Uffe
>
> Signed-off-by: Angelo Dureghello <angelo <at> sysam.it>
>
> diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
> index 5d4c5e0..65d4990 100644
> --- a/drivers/mmc/host/davinci_mmc.c
> +++ b/drivers/mmc/host/davinci_mmc.c
> @@ -439,8 +439,8 @@ static int mmc_davinci_send_dma_request(struct
> mmc_davinci_host *host,
> DMA_MEM_TO_DEV,
> DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
> if (!desc) {
> - dev_dbg(mmc_dev(host->mmc),
> - "failed to allocate DMA TX descriptor");
> + WARN(1, KERN_WARNING
> + "failed to allocate DMA TX descriptor\n");
> ret = -1;
> goto out;
> }
> @@ -461,8 +461,8 @@ static int mmc_davinci_send_dma_request(struct
> mmc_davinci_host *host,
> DMA_DEV_TO_MEM,
> DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
> if (!desc) {
> - dev_dbg(mmc_dev(host->mmc),
> - "failed to allocate DMA RX descriptor");
> + WARN(1, KERN_WARNING
> + "failed to allocate DMA RX descriptor\n");
> ret = -1;
> goto out;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
