On Sat, Sep 13, 2014 at 4:18 PM, Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote: > On Fri, Sep 12, 2014 at 06:23:02PM +0800, Chen-Yu Tsai wrote: >> > mmc0: mmc@01c0f000 { >> > compatible = "allwinner,sun4i-a10-mmc"; >> > reg = <0x01c0f000 0x1000>; >> > - clocks = <&ahb_gates 8>, <&mmc0_clk>; >> > - clock-names = "ahb", "mmc"; >> > + clocks = <&ahb_gates 8>, >> > + <&mmc0_clk>, >> > + <&mmc0_sample_clk>, >> > + <&mmc0_output_clk>; >> > + clock-names = "ahb", >> > + "mmc", >> > + "sample", >> > + "output"; >> >> Just a stylish nitpick. All the other resources in these files >> are listed inline if possible, not one phandle/value per line. > > Look at the PIO interrupts, every USB PHY resources, etc. ;) I guess we need some styling cleanups. :) ChenYu -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html