On Fri, Sep 12, 2014 at 06:23:02PM +0800, Chen-Yu Tsai wrote: > > mmc0: mmc@01c0f000 { > > compatible = "allwinner,sun4i-a10-mmc"; > > reg = <0x01c0f000 0x1000>; > > - clocks = <&ahb_gates 8>, <&mmc0_clk>; > > - clock-names = "ahb", "mmc"; > > + clocks = <&ahb_gates 8>, > > + <&mmc0_clk>, > > + <&mmc0_sample_clk>, > > + <&mmc0_output_clk>; > > + clock-names = "ahb", > > + "mmc", > > + "sample", > > + "output"; > > Just a stylish nitpick. All the other resources in these files > are listed inline if possible, not one phandle/value per line. Look at the PIO interrupts, every USB PHY resources, etc. ;) Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature