On 18 August 2014 19:13, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > On Mon, Aug 18, 2014 at 11:39 AM, kbuild test robot > <fengguang.wu@xxxxxxxxx> wrote: > >> tree: git://git.linaro.org/people/ulf.hansson/mmc next >> head: 612b2c14449ba90b633f51fcfba83dd66614697a >> commit: f907645be3f76558c3eb89bdd72e3451a762059c [17/29] mmc: select GPIOLIB for MMC support >> config: make ARCH=s390 allmodconfig >> >> All warnings: >> >> warning: (ARCH_REQUIRE_GPIOLIB && MMC && PINCTRL_AT91 && PINCTRL_NOMADIK && MFD_TC6393XB && FB_VIA) selects GPIOLIB which has unmet direct dependencies (ARCH_WANT_OPTIONAL_GPIOLIB || ARCH_REQUIRE_GPIOLIB) >> drivers/input/touchscreen/cyttsp4_core.c: In function 'cyttsp4_irq': >>>> drivers/input/touchscreen/cyttsp4_core.c:1218:1: warning: 'cyttsp4_irq' uses dynamic stack allocation > > This error comes from selecting something that is optional. > > Grrr should I use "depends on GPIOLIB" for MMC instead? Not sure that will be any better. > > Or maybe even do the second approach of putting stubs in slot-gpio.h > for !GPIOLIB... Hmm, that doesn't sound the proper solution either. Currently there are already stubs for the "gpiod" API in gpio/consumer.h. I think the original error was that the "GPIOD_IN" flag couldn't be found for !GPIOLIB. So, how about actually move these flags and it's corresponding defines to be available for !GPIOLIB as well. That should solve this problem for other subsytems using gpiod API as well, right? Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
