On Tue, May 27, 2014 at 4:21 PM, Chen-Yu Tsai <wens@xxxxxxxx> wrote: > On Tue, May 27, 2014 at 10:11 PM, Linus Walleij >> I tried to hack the sunxi driver to even use the gpiolib >> irqchip helpers but exactly this complex map thing in >> ->irq_array[] git me stuck. If any of you guys could be so >> nice to take a stab at this (compare to other commits >> converting drivers to use gpiolibs irqchip helpers) then >> I'd be very happy. > > We still need to rework the whole irqchip stuff for sun6i/sun8i, > which have 1 parent interrupt per EINT capable pin bank. > > Earlier discussions with Maxime (on IRC IIRC) suggested moving this > over to gpiolib irqchip helpers might be more work than using our own > irqchip implementation, requiring 1 gpiochip per pin group? (not sure) OK then keep your current code. I do not intend to cover all cases in the world with these helpers, just the simple cases. Complex hardware merits complex code. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html