Re: [PATCH v3 13/13] mmc: mmci: Add Qcom specific pio_read function.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 28/05/14 09:08, Linus Walleij wrote:
On Fri, May 23, 2014 at 2:53 PM,  <srinivas.kandagatla@xxxxxxxxxx> wrote:

+       if (unlikely(bytes)) {
+               unsigned char buf[4];
(...)


Please think twice about this.
http://lwn.net/Articles/70473/
http://lwn.net/Articles/420019/
http://lwn.net/Articles/182369/

Thanks for the warning.

You are right. I think having likely/unlikely is not always right here.

thanks,
srini
Yours,
Linus Walleij

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux