Re: [PATCH 1/1] mmc: sdhci-esdhc-imx: fix mmc ddr mode regression issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27 May 2014 16:05, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> Hi Ulf,
>
> On Fri, May 9, 2014 at 5:42 AM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
>> On 9 May 2014 08:53, Dong Aisheng <b29396@xxxxxxxxxxxxx> wrote:
>>> The regression is caused by the following commit ...
>>>
>>> commit 79f7ae7c45a6ccf04e2908337461dee615f6afb0
>>> Author: Seungwon Jeon <tgih.jun@xxxxxxxxxxx>
>>> Date:   Fri Mar 14 21:11:56 2014 +0900
>>>
>>> mmc: clarify DDR timing mode between SD-UHS and eMMC
>>>
>>> This change distinguishes DDR timing mode of current
>>> mixed usage to clarify device type.
>>>
>>> Signed-off-by: Seungwon Jeon <tgih.jun@xxxxxxxxxxx>
>>> Acked-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
>>> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>>> Signed-off-by: Chris Ball <chris@xxxxxxxxxx>
>>>
>>> ... and the line below.
>>>
>>> @@ -1264,7 +1264,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
>>> goto err;
>>>         }
>>>                 mmc_card_set_ddr_mode(card);
>>> -               mmc_set_timing(card->host, MMC_TIMING_UHS_DDR50);
>>> +               mmc_set_timing(card->host, MMC_TIMING_MMC_DDR52);
>>>                 mmc_set_bus_width(card->host, bus_width);
>>>         }
>>> }
>>>
>>> It's caused by the platform driver was still using MMC_TIMING_UHS_DDR50 for MMC DDR
>>> mode which needs update too.
>>>
>>> Reported-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
>>> Reported-by: Shawn Guo <shawn.guo@xxxxxxxxxxxxx>
>>> Signed-off-by: Dong Aisheng <b29396@xxxxxxxxxxxxx>
>>
>> Hi Dong,
>>
>> Thanks for the fix. I will include this in the next PR I send to Chris.
>
> It seems this one is still missing in linux-next.

The patch is applied to Chris' mmc tree. Currently, Stehpen can't
merge the latest version of Chris' tree since we have mange to break
it. :-)

I hope Chris will merge the following patch to his tree the next few
days, that will solve the problem.
[PATCH] mmc: sdhci-s3c: use mmc_of_parse and remove the card_tasklet

Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux