On Tue, Jan 14, 2014 at 7:58 AM, Kevin Hilman <khilman@xxxxxxxxxx> wrote: > On Thu, Jan 9, 2014 at 6:35 AM, Zhangfei Gao <zhangfei.gao@xxxxxxxxxx> wrote: >> Suggested by Jaehoon: Use slot-gpio to handle cd-gpio >> Add function dw_mci_of_get_cd_gpio to check "cd-gpios" from dts. >> mmc_gpio_request_cd and mmc_gpio_get_cd are used to handle cd pin >> >> Signed-off-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx> >> Acked-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx> > > The Samsung Arndale board started failing boot from MMC root tests > starting with next-20140113 and I bisected it down to this patch. > Reverting this patch on top of next-20140114 gets Arndale booting > again from MMC. Is there some supporting DT data that's missing for > Arndale? Rather, it looks like this patch changes behaviour and no longer uses dw_mci_get_cd() to find out if there's a card attached -- it switches to rely only on GPIO (see the last chunk in the patch). That seems broken? -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
