On 12 September 2013 13:52, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote: > sdhci_probe only checks for IS_ERR. We would need to change it to > IS_ERR_OR_NULL (which I do not prefer personally as there is some > discussion for its removal). In that case we would need to return as I > mentioned in my earlier email. Let me know your opinion. The problem with pdata normally is that it can't be NULL. Its not like clk/ regulator framework where NULL's are valid... And that's why we are checking NULL later in the probe().. Probably you can just move that up a bit.. and nothing else.. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
