Re: [PATCH 1/1] mmc: sdhci-spear: Fix NULL pointer dereference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12 September 2013 13:50, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> On 12 September 2013 13:48, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
>>>>  96      return ERR_PTR(-ENODATA);
>>
>> Wouldn't this be unconditional error return whether pdata is null or not?
>
> Stupid me... I meant return pdata from this place..
>
> Necessary checks are done in sdhci_probe()

sdhci_probe only checks for IS_ERR. We would need to change it to
IS_ERR_OR_NULL (which I do not prefer personally as there is some
discussion for its removal). In that case we would need to return as I
mentioned in my earlier email. Let me know your opinion.

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux