On Wed, Sep 04, 2013 at 08:54:10PM +0800, Dong Aisheng wrote:
> The tuning of some platforms may not follow the standard host control
> spec v3.0, e.g. Freescale uSDHC on i.MX6Q/DL.
> Add a hook here to allow execute platform specific tuning instead of
> standard host controller tuning.
>
> Signed-off-by: Dong Aisheng <b29396@xxxxxxxxxxxxx>
> ---
> drivers/mmc/host/sdhci.c | 8 ++++++++
> drivers/mmc/host/sdhci.h | 1 +
> 2 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index dd2c083..2890cfd 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1875,6 +1875,14 @@ static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode)
> return 0;
> }
>
> + if (host->ops->platform_execute_tuning) {
> + spin_unlock(&host->lock);
> + enable_irq(host->irq);
Hmm, you want these two functions be called before
platform_execute_tuning()? That probably means you do not need to call
spin_lock() and disable_irq() for platform_execute_tuning()? In that
case, can we not just put this platform hook at the beginning of the
function, something like below?
host = mmc_priv(mmc);
if (host->ops->platform_execute_tuning) {
sdhci_runtime_pm_get(host);
err = host->ops->platform_execute_tuning(host, opcode);
sdhci_runtime_pm_put(host);
}
I guess that's more clear to tell that platform_execute_tuning hook is
there to replace sdhci_execute_tuning() completely. Is it the case?
Shawn
> + err = host->ops->platform_execute_tuning(host, opcode);
> + sdhci_runtime_pm_put(host);
> + return err;
> + }
> +
> sdhci_writew(host, ctrl, SDHCI_HOST_CONTROL2);
>
> /*
> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> index b037f18..976c14b 100644
> --- a/drivers/mmc/host/sdhci.h
> +++ b/drivers/mmc/host/sdhci.h
> @@ -288,6 +288,7 @@ struct sdhci_ops {
> unsigned int (*get_ro)(struct sdhci_host *host);
> void (*platform_reset_enter)(struct sdhci_host *host, u8 mask);
> void (*platform_reset_exit)(struct sdhci_host *host, u8 mask);
> + int (*platform_execute_tuning)(struct sdhci_host *host, u32 opcode);
> int (*set_uhs_signaling)(struct sdhci_host *host, unsigned int uhs);
> void (*hw_reset)(struct sdhci_host *host);
> void (*platform_suspend)(struct sdhci_host *host);
> --
> 1.7.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
