Seungwon Jeon, On Mon, Jul 15, 2013 at 5:09 AM, Seungwon Jeon <tgih.jun@xxxxxxxxxxx> wrote: > On Thu, July 11, 2013, Doug Anderson wrote: >> On some devices (like exynos5420) the dw_mmc controller may be in a >> strange state after we wake up from sleep. Add callbacks to allow for >> dealing with these quirks. We use the "_noirq" versions of the >> callbacks since in the case of exynos5420 the strange state caused >> interrupts to fire so we need to deal with it while interrupts are >> still off. >> >> At the moment this support is only added to dw_mmc-pltfm which calls >> straight to the callback, since nobody but exynos needs it. We can >> add some levels of indirection (a call into the generic dw_mmc code) >> when someone finds a need. > I think It would be better to add _noirq only to dw_mmc-exynos. > That is we can add dev_pm_ops for dw_mmc-exynos's own. > As you recognize, there is no common routine which is not introduced for dw_mmc xxx_noirq now. > I feel like it is for handling quirk. > If we meet use case for that in some day, it could be added commonly. > How do you think? > > Thanks, > Seungwon Jeon Sorry for the long delay in responding. I originally didn't do what you proposed since dw_mmc-exynos uses the dw_mci_pltfm_pmops directly. ...but I agree that it is cleaner, so I've switched the code to do as you say. New patch coming shortly. Thank you for your review. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
