On Friday, August 02, 2013 5:34 PM, Dan Carpenter wrote: > On Fri, Aug 02, 2013 at 09:11:19AM +0900, Jingoo Han wrote: > > On Friday, August 02, 2013 1:19 AM, Dinh Nguyen wrote: [...] > > > drivers/mmc/host/dw_mmc-pltfm.c:36:5: warning: symbol > > > 'dw_mci_pltfm_register' was not declared. Should it be static? > > > drivers/mmc/host/dw_mmc-pltfm.c:94:1: warning: symbol > > > 'dw_mci_pltfm_pmops' was not declared. Should it be static? > > > > 'dw_mci_pltfm_register' and 'dw_mci_pltfm_pmops' are exported as below: > > > > 70: EXPORT_SYMBOL_GPL(dw_mci_pltfm_register); > > 95: EXPORT_SYMBOL_GPL(dw_mci_pltfm_pmops); > > > > So, I am not sure whether these can be static or not. :( > > Dan, if you know how to handle this, please let me know. > > No, don't make these static. The way to silence this warning is to > include "dw_mmc-pltfm.h". I really appreciate your answer. :) Then, I will send the patch to include "dw_mmc-pltfm.h". Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html