Hi,
On Thu, 2013-08-01 at 15:30 +0900, Jingoo Han wrote:
> dw_mci_socfpga_probe() is used only in this file.
> Fix the following sparse warning:
>
> drivers/mmc/host/dw_mmc-socfpga.c:116:5: warning: symbol 'dw_mci_socfpga_probe' was not declared. Should it be static?
>
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> ---
> drivers/mmc/host/dw_mmc-socfpga.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-socfpga.c b/drivers/mmc/host/dw_mmc-socfpga.c
> index 14b5961..35aebb8 100644
> --- a/drivers/mmc/host/dw_mmc-socfpga.c
> +++ b/drivers/mmc/host/dw_mmc-socfpga.c
> @@ -113,7 +113,7 @@ static const struct of_device_id dw_mci_socfpga_match[] = {
> };
> MODULE_DEVICE_TABLE(of, dw_mci_socfpga_match);
>
> -int dw_mci_socfpga_probe(struct platform_device *pdev)
> +static int dw_mci_socfpga_probe(struct platform_device *pdev)
> {
> const struct dw_mci_drv_data *drv_data;
> const struct of_device_id *match;
This looks good but do you care to fix the other sparse warnings for
dw_mmc-pltfm.c too?
drivers/mmc/host/dw_mmc-pltfm.c:58:24: warning: incorrect type in
argument 1 (different address spaces)
drivers/mmc/host/dw_mmc-pltfm.c:58:24: expected void const *ptr
drivers/mmc/host/dw_mmc-pltfm.c:58:24: got void [noderef]
<asn:2>*regs
drivers/mmc/host/dw_mmc-pltfm.c:59:36: warning: incorrect type in
argument 1 (different address spaces)
drivers/mmc/host/dw_mmc-pltfm.c:59:36: expected void const *ptr
drivers/mmc/host/dw_mmc-pltfm.c:59:36: got void [noderef]
<asn:2>*regs
drivers/mmc/host/dw_mmc-pltfm.c:36:5: warning: symbol
'dw_mci_pltfm_register' was not declared. Should it be static?
drivers/mmc/host/dw_mmc-pltfm.c:94:1: warning: symbol
'dw_mci_pltfm_pmops' was not declared. Should it be static?
Dinh
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
