Re: [PATCH v3 5/7] mmc: SDHI: add DT compatibility strings for further SoCs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 08, 2013 at 11:09:07PM -0700, Kuninori Morimoto wrote:
> 
> Hi Guennadi
> 
> > diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c
> > index cc4c872..b58c1a9 100644
> > --- a/drivers/mmc/host/sh_mobile_sdhi.c
> > +++ b/drivers/mmc/host/sh_mobile_sdhi.c
> > @@ -130,6 +130,9 @@ static const struct of_device_id sh_mobile_sdhi_of_match[] = {
> >  	{ .compatible = "renesas,shmobile-sdhi" },
> >  	{ .compatible = "renesas,sh7372-sdhi" },
> >  	{ .compatible = "renesas,r8a7740-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], },
> > +	{ .compatible = "renesas,sh73a0-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], },
> > +	{ .compatible = "renesas,r8a73a4-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], },
> > +	{ .compatible = "renesas,r8a7790-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], },
> >  	{},
> 
> According to HW people, latest Renesas chip needs "TMIO_MMC_HAS_IDLE_WAIT".
> Could you plase add r8a7778 / r8a7779 here ?
> 
> # or we can use common compatible name for it ?

Hi Guennadi,

could you please address Morimoto-san's review?
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux