James, On Tue, Jul 9, 2013 at 2:17 PM, James Hogan <james.hogan@xxxxxxxxxx> wrote: > Hi Doug, > > On 9 July 2013 18:31, Doug Anderson <dianders@xxxxxxxxxxxx> wrote: >> On some platforms (like exynos5420) the dw_mmc controller may be in a >> strange state after we wake up from sleep. Add callbacks to allow for >> dealing with these quirks. Prevent interrupts from firing when we're >> suspended since this strange state may cause interrupts to fire. >> >> In my case I saw the WAKEUP_INT interrupt firing upon resume and >> needed to add some code to handle this. >> >> Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx> > > Would it make sense to take advantage of the {suspend,resume}_noirq > power management callbacks to clear that WAKEUP_INT before interrupts > are re-enabled, rather than explicitly disabling and enabling the > interrupt at the suspend/resume stage? That's a good suggestion. Let me give it a shot and get back to you after I validate that it works. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html