On Wed, Apr 10, 2013 at 06:56:48AM -0700, Doug Anderson wrote: > Thomas, > > On Wed, Apr 10, 2013 at 5:48 AM, Thomas Abraham > <thomas.abraham@xxxxxxxxxx> wrote: > > The call to regulator_enable() is prior to the call to mmc_add_host(). > > Hence, call to mmc_fre_host is not required in this case. So the above > > change should be right. > > Are you sure that mmc_free_host() is the opposite of mmc_add_host() > and not mmc_alloc_host()? mmc_free_host() undoes mmc_alloc_host(). mmc_remove_host() undoes mmc_add_host(). alloc add remove free is pretty standard terminology, standard ordering. If add fails, then free is the right thing to call to clean up after the alloc. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html