On 10 April 2013 05:00, Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
> Thomas,
>
> On Mon, Apr 8, 2013 at 10:59 PM, Thomas Abraham
> <thomas.abraham@xxxxxxxxxx> wrote:
>> @@ -2002,7 +1994,7 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id)
>> if (ret) {
>> dev_err(host->dev,
>> "failed to enable regulator: %d\n", ret);
>> - goto err_setup_bus;
>> + return ret;
>
> It seems like you'd need a "mmc_free_host(mmc);" in this case don't
> you? AKA: this should be a goto and not a return.
Hi Doug,
The call to regulator_enable() is prior to the call to mmc_add_host().
Hence, call to mmc_fre_host is not required in this case. So the above
change should be right.
Thanks,
Thomas.
>
> -Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
