Re: [PATCH] mmc: core: restore ocr and operation voltage in resume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ulf Hansson <ulf.hansson <at> linaro.org> writes:

> "host->ocr" is intended for keeping the negotiated ocr mask. Another
> variable is not needed.
> 
> A proper patch would in principle remove the workaround, which means
> the reset of the "host->ocr" in mmc_power_off is not done any more.
> 
> Exactly what you need to make this work, is as stated before a bit
> more complicated.

Hello Ulf,

The work around is introduced by yourself :-
"At power off, reset OCR mask to be the highest possible voltage
supported for the current mmc host.

This solves the re-initialization during the power up sequence.
The voltage may have been decreased due to the card accepts a lower
voltage than the voltage used during the initialization sequence.
We need to reset the voltage to by the host highest possible value
since according to _specification_ the initialization must always be
done at high voltage"

So do you think, solution to current issue is to revert this patch? This 
will not violate the spec as you are mentioning above?
If you agree, i'll push a new patch by reverting this. Else consider another 
way in my new post "mmc: core: negotiate ocr during resume"
This patch will follow the spec and will also negotiate ocr during 
mmc_resume_host.

Thanks,
Prasanna NAVARATNA

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux