On 4 April 2013 16:43, Prasanna NAVARATNA <prasanna.navaratna@xxxxxxxxx> wrote: > Prasanna NAVARATNA <prasanna.navaratna <at> gmail.com> writes: > >> >> So you agree the ocr mask must not be reset during suspend. >> >> The patch over here exactly addresses the problem which you stated :- >> "mmc core should tell the host driver to use the properly negotiated ocr >> mask to set the voltage level, both at initialization and at resume" >> >> The patch saves the ocr which is properly negotiated during initialization >> time and then restores it back during resume. >> >> Will you please elaborate, what is wrong with this patch? Or are you > trying >> to tell, this is not the proper way to do the same? "host->ocr" is intended for keeping the negotiated ocr mask. Another variable is not needed. A proper patch would in principle remove the workaround, which means the reset of the "host->ocr" in mmc_power_off is not done any more. Exactly what you need to make this work, is as stated before a bit more complicated. >> >> Thanks & Regards, >> Prasanna NAVARATNA >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> the body of a message to majordomo <at> vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> > > Hello, > > I have suggested another patch which does the same thing in better way. > Please refer to the new post "mmc: core: negotiate ocr during resume" > > Regards, > Prasanna NAVARATNA > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
