RE: [PATCH] mmc: dw_mmc: read all data in FIFO after Data transfer over interrupt in pio mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 21, 2013 at 7:45 PM, Will Newton wrote:
> 
> On Mon, Jan 21, 2013 at 10:19 AM, Kyoungil Kim <ki0351.kim@xxxxxxxxxxx> wrote:
> > In dwc manual, the below contents are described.
> > "During end of packet, interrupt is not generated if threshold
> > programming is larger than any remaining data. It is responsibility
> > of host to read remaining bytes on seeing Data Transfer Done
> > interrupt"
> > We also have seen the data cannot be read fully
> > when "sg_miter->length" is less than FIFO size.
> >
> > Signed-off-by: Kyoungil Kim <ki0351.kim@xxxxxxxxxxx>
> > Signed-off-by: Seungwon Jeon <tgih.jun@xxxxxxxxxxx>
> > ---
> >  drivers/mmc/host/dw_mmc.c |   11 +++++++----
> >  1 files changed, 7 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> > index 323c502..afcc0f4 100644
> > --- a/drivers/mmc/host/dw_mmc.c
> > +++ b/drivers/mmc/host/dw_mmc.c
> > @@ -1430,7 +1430,7 @@ static void dw_mci_pull_data(struct dw_mci *host, void *buf, int cnt)
> >         host->pull_data(host, buf, cnt);
> >  }
> >
> > -static void dw_mci_read_data_pio(struct dw_mci *host)
> > +static void dw_mci_read_data_pio(struct dw_mci *host, u8 int_data_over)
> 
> The data_over argument should probably be a bool.

Thank you.
I'll apply and submit again.

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux