RE: [PATCH 2/2] Powerpc/eSDHC: Add limit to data and erase timeout value calculation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Regards
Haijun.


> -----Original Message-----
> From: Anton Vorontsov [mailto:cbouatmailru@xxxxxxxxx]
> Sent: Monday, November 19, 2012 1:05 PM
> To: Zhang Haijun-B42677
> Cc: linux-mmc@xxxxxxxxxxxxxxx; Huang Changming-R66093
> Subject: Re: [PATCH 2/2] Powerpc/eSDHC: Add limit to data and erase
> timeout value calculation
> 
> On Mon, Nov 19, 2012 at 11:38:29AM +0800, Haijun Zhang wrote:
> > Some cards apply too larg timeout value for host to response, So limit
> > the maximum data transfer timeout value and maximum erase timeout
> > value to aviod timeout issue.
> >
> > Signed-off-by: Haijun Zhang <Haijun.Zhang@xxxxxxxxxxxxx>
> > Signed-off-by: Jerry Huang <Chang-Ming.Huang@xxxxxxxxxxxxx>
> > Signed-off-by: Anton Vorontsov <cbouatmailru@xxxxxxxxx>
> 
> Ditto about the sign-off, it's inappropriate in this case.


[Haijun: ] Sorry.
So, replace signed-off-by with Acked-by?

> 
> [...]
> > @@ -721,6 +722,10 @@ void mmc_set_data_timeout(struct mmc_data *data,
> const struct mmc_card *card)
> >  				data->timeout_ns =  100000000;	/* 100ms */
> >  		}
> >  	}
> > +
> > +	if (host->max_discard_to &&
> > +		host->max_discard_to < div_u64(data->timeout_ns, 1000000))
> 
> Still wrong indentation.

[Haijun: ] Did you mean here need two tabs not one ?

> 
> > +		data->timeout_ns = (u64)host->max_discard_to * 1000000;
> >  }
> >  EXPORT_SYMBOL(mmc_set_data_timeout);

��.n��������+%������w��{.n�����{��i��)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux