Hi, On Wed, Oct 17 2012, Kevin Liu wrote: > From: Kevin Liu <kliu5@xxxxxxxxxxx> > > 1. The vmmc regulator enable in sdhci_add_host is NOT necessary since > it can be enabled during mmc_power_up by function mmc_regulator_set_ocr. > And this extra enable will make regulator_enable/regulator_disable > unbalanced. Consequently, vmmc can't be disabled during mmc_power_off. > > 2. If regulator vqmmc exist, it should be enabled regardless it support > 1.8v or not. > > 3. If regulator framework is disabled, regulator_get will return NULL. > So the CONFIG_REGULATOR judgement can be removed. Pushed to mmc-next for 3.8 without "3." above, because it causes a compile error -- now we use regulator_count_voltages() inside that block and it's not a stub function in the regulator API, so the ifdef is required. - Chris. -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
