On 16/11/12 13:30, Girish K S wrote: > On 16 November 2012 18:51, Srinivas KANDAGATLA > <srinivas.kandagatla@xxxxxx> wrote: >> From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxx> >> >> This patch uses of_simple_module_id_table macro to replace code like: >> >> #ifdef CONFIG_OF >> static struct of_device_id xxx_of_match[] = { >> { .compatible = "yyy,xxx" }, >> { }, >> }; >> MODULE_DEVICE_TABLE(of, xxx_of_match); >> #endif >> >> with >> of_simple_module_id_table(xxx_of_match, "yyy,zzz"); >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxx> >> --- >> drivers/mmc/host/dw_mmc-exynos.c | 7 +------ >> 1 files changed, 1 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c >> index 660bbc5..1e9596a 100644 >> --- a/drivers/mmc/host/dw_mmc-exynos.c >> +++ b/drivers/mmc/host/dw_mmc-exynos.c >> @@ -218,12 +218,7 @@ static struct dw_mci_drv_data exynos5250_drv_data = { >> .setup_bus = dw_mci_exynos_setup_bus, >> }; >> >> -static const struct of_device_id dw_mci_exynos_match[] = { >> - { .compatible = "samsung,exynos5250-dw-mshc", >> - .data = (void *)&exynos5250_drv_data, }, >> - {}, >> -}; > Here's the problem. You are missing the driver data for the exynos > SoC. this is very much required. > where's the .data = (void *)&exynos5250_drv_data,? Thanks for looking, Yep, You are correct. >> -MODULE_DEVICE_TABLE(of, dw_mci_pltfm_match); >> +of_simple_module_id_table(dw_mci_pltfm_match, "samsung,exynos5250-dw-mshc"); >> >> int dw_mci_exynos_probe(struct platform_device *pdev) >> { >> -- >> 1.7.0.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html