On Mon, Aug 20, 2012 at 02:30:01PM +0530, Shubhrajyoti Datta wrote: > On Mon, Aug 20, 2012 at 12:25 PM, Shilimkar, Santosh > <santosh.shilimkar@xxxxxx> wrote: > > On Mon, Aug 20, 2012 at 12:08 PM, S, Venkatraman <svenkatr@xxxxxx> wrote: > >> > >> On Fri, Aug 17, 2012 at 11:43 PM, Puttagunta, Viswanath <vishp@xxxxxx> > >> wrote: > [...] > >> >>> Signed-off-by: Semen Protsenko <semen.protsenko@xxxxxx> > >> >> > >> >> The implementation looks fine, but can we simply not set the errata > >> >> flag and make this as default > >> >> behaviour ? I suppose the documented behaviour with CSRE and RSP10 is > >> >> independent of the > >> >> errata.. > >> >> > >> >> Also, please send it to the linux-mmc list as well. > >> > > >> > Vish>> We don't know if this errata effects OMAP5 as well. So, I think > >> > we should only do this if we are OMAP4. > >> > > >> That's precisely why the code shouldn't check for cpu_() flags. There are > >> other > >> OMAP variants as well and we can't check all of them > >> What I mean is to make the check for RSP10 and CSRE all the time as part > >> of the IRQ check. > >> Then it equally applies to silcon with or without errata. > > > > Apart from above comment, please don't add the cpu_is_xxx() check inside > > device driver. You can pass that information from platform code > > while registering the MMC controllers using a flag and then just > > use that flag to enable/disable errata in the driver. > > The other option is to check something like MMCHS_HL_REV to get the ip revision > and decide. If the revision register is broken, please don't pass a flag. Use different compatible attributes and/or platform_device_id structures to make sure you can differentiate the versions on the driver itself without any needs to use cpu_is_* or pass flags. -- balbi
Attachment:
signature.asc
Description: Digital signature
