Hi Thomas, Am Donnerstag, 16. August 2012, 17:49:29 schrieb Thomas Abraham: > Add device tree based discovery support for Samsung's sdhci controller > > Cc: Ben Dooks <ben-linux@xxxxxxxxx> > Cc: Kukjin Kim <kgene.kim@xxxxxxxxxxx> > Cc: Chris Ball <cjb@xxxxxxxxxx> > Signed-off-by: Thomas Abraham <thomas.abraham@xxxxxxxxxx> > --- > drivers/mmc/host/sdhci-s3c.c | 146 > ++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 140 > insertions(+), 6 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c > index a50c205..7fcc642 100644 > --- a/drivers/mmc/host/sdhci-s3c.c > +++ b/drivers/mmc/host/sdhci-s3c.c [...] > @@ -737,6 +860,16 @@ static struct platform_device_id > sdhci_s3c_driver_ids[] = { }; > MODULE_DEVICE_TABLE(platform, sdhci_s3c_driver_ids); > > +#ifdef CONFIG_OF > +static const struct of_device_id sdhci_s3c_dt_match[] = { > + { .compatible = "samsung,s3c6410-sdhci", }, > + { .compatible = "samsung,exynos4210-sdhci", > + .data = &exynos4_sdhci_drv_data }, Please use the EXYNOS4_SDHCI_DRV_DATA constant here. Otherwise other Samsung platforms experimenting with dt will break. Thanks Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html