Hi Jaehun. I have sent the similar to your patch. (http://www.spinics.net/lists/linux-mmc/msg10305.html) I think good that add the checking point whether implement hold_reg in dwmmc-IP or not. On 03/19/2012 06:26 PM, JaeHun Jung wrote: > use_hold_reg bit is added at 240A version. > This register is.. > Use Hold Register > 0 - CMD and DATA sent to card bypassing HOLD Register > 1 - CMD and DATA sent to card through the HOLD Register > Note: > Set to 1'b1 for SDR12 and SDR25 > (with non-zero phase-shifted cclk_in_drv) > zero phase shift is not allowed in these modes. > Set to 1'b0 for SDR50, SDR104, and DDR50 > (with zero phaseshifted cclk_in_drv) > Set to 1'b1 for SDR50, SDR104, and DDR50 > (with non-zero phase-shifted cclk_in_drv) > > Signed-off-by: JaeHun Jung <jh0801.jung@xxxxxxxxxxx> > --- > drivers/mmc/host/dw_mmc.c | 5 +++++ > drivers/mmc/host/dw_mmc.h | 1 + > 2 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 8bec1c3..e23bd5b 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -232,6 +232,7 @@ static void dw_mci_set_timeout(struct dw_mci *host) > static u32 dw_mci_prepare_command(struct mmc_host *mmc, struct mmc_command *cmd) > { > struct mmc_data *data; > + struct dw_mci_slot *slot = mmc_priv(mmc); > u32 cmdr; > cmd->error = -EINPROGRESS; > > @@ -261,6 +262,10 @@ static u32 dw_mci_prepare_command(struct mmc_host *mmc, struct mmc_command *cmd) > cmdr |= SDMMC_CMD_DAT_WR; > } > > + /* Use hold bit register */ > + if (slot->host->pdata->set_io_timing) > + cmdr |= SDMMC_USE_HOLD_REG; Where is defined set_io_timing? > + > return cmdr; > } > > diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h > index df392a1..06c2818 100644 > --- a/drivers/mmc/host/dw_mmc.h > +++ b/drivers/mmc/host/dw_mmc.h > @@ -111,6 +111,7 @@ > #define SDMMC_INT_ERROR 0xbfc2 > /* Command register defines */ > #define SDMMC_CMD_START BIT(31) > +#define SDMMC_USE_HOLD_REG BIT(29) > #define SDMMC_CMD_CCS_EXP BIT(23) > #define SDMMC_CMD_CEATA_RD BIT(22) > #define SDMMC_CMD_UPD_CLK BIT(21) Best Regards, Jaehoon Chung -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
