On Wed, Mar 14, 2012 at 08:09:22AM +0100, Marek Vasut wrote:
> Dear Dong Aisheng,
>
> > On Wed, Mar 14, 2012 at 01:58:25PM +0800, Marek Vasut wrote:
> > > Dear Dong Aisheng,
> > >
> > > > Signed-off-by: Dong Aisheng <dong.aisheng@xxxxxxxxxx>
> >
> > ........
> >
> > > > +static const struct of_device_id mxs_mmc_dt_ids[] = {
> > > > + { .compatible = "fsl,imx23-mmc", .data = NULL, },
> > > > + { .compatible = "fsl,imx28-mmc", .data = NULL, },
> > >
> > > Do you really need two distinct ones here?
> >
> > Hmm, my original purpose is to put soc difference data in .data
> > to remove cpu_is_* function calls in the driver later.
> > Do you think if any issue?
> >
>
> Well, what's the difference between the interfaces on mx233 and mx28? Is it
> something that can't be encoded otherwise? I think they're not so different.
They differ in the register layout. Matching two different compatible
strings is the right way here I think.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
