On Wed, Mar 14, 2012 at 01:58:25PM +0800, Marek Vasut wrote: > Dear Dong Aisheng, > > > > > Signed-off-by: Dong Aisheng <dong.aisheng@xxxxxxxxxx> ........ > > +static const struct of_device_id mxs_mmc_dt_ids[] = { > > + { .compatible = "fsl,imx23-mmc", .data = NULL, }, > > + { .compatible = "fsl,imx28-mmc", .data = NULL, }, > > Do you really need two distinct ones here? > Hmm, my original purpose is to put soc difference data in .data to remove cpu_is_* function calls in the driver later. Do you think if any issue? Regards Dong Aisheng -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html