Hi. I added James and Will to CC. Best Regards, Jaehoon Chung 2012/2/17 <Hyeonsu@xxxxxxxxxxxxxxx>: > From: Hyeonsu Kim <hyeonsu.kim@xxxxxxxxxxx> > > Why need to set EVENT_DATA_COMPLETE bit in here? > I think this is duplication bit-set. > because The bit is already set when occur SDMMC_INT_DATA_OVER interrupt. > > In my case (I use dw_mmc for sd card), the bit brings about data transfer fault. > So I want to know your idea about the bit-set. > > Signed-off-by: Hyeonsu Kim <hyeonsu.kim@xxxxxxxxxxx> > --- > drivers/mmc/host/dw_mmc.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 0e34279..edc60d1 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -1550,7 +1550,6 @@ static irqreturn_t dw_mci_interrupt(int irq, void *dev_id) > if (pending & (SDMMC_IDMAC_INT_TI | SDMMC_IDMAC_INT_RI)) { > mci_writel(host, IDSTS, SDMMC_IDMAC_INT_TI | SDMMC_IDMAC_INT_RI); > mci_writel(host, IDSTS, SDMMC_IDMAC_INT_NI); > - set_bit(EVENT_DATA_COMPLETE, &host->pending_events); > host->dma_ops->complete(host); > } > #endif > -- > 1.7.5.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html