RE: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Aaron Lu [mailto:aaron.lu@xxxxxxx]
> Sent: Friday, January 13, 2012 2:32 PM
> To: Huang Changming-R66093
> Cc: linux-mmc@xxxxxxxxxxxxxxx; Chris Ball
> Subject: Re: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on()
> 
> Hi,
> 
> On Fri, Jan 13, 2012 at 03:39:53AM +0000, Huang Changming-R66093 wrote:
> >
> >
> > > -----Original Message-----
> > > From: Aaron Lu [mailto:aaron.lu@xxxxxxx]
> > > Sent: Friday, January 13, 2012 11:27 AM
> > > To: Huang Changming-R66093
> > > Cc: linux-mmc@xxxxxxxxxxxxxxx; Chris Ball
> > > Subject: Re: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on()
> > >
> > > Hi,
> > >
> > > On Fri, Jan 13, 2012 at 02:24:46AM +0000, Huang Changming-R66093
> wrote:
> > > > Hi, Chris,
> > > > Could you have any comment about this patch?
> > > > Can it go into 3.3 or 3.4?
> > > >
> > > > > -----Original Message-----
> > > > > From: Huang Changming-R66093
> > > > > Sent: Friday, December 09, 2011 10:54 AM
> > > > > To: linux-mmc@xxxxxxxxxxxxxxx
> > > > > Cc: Huang Changming-R66093; Chris Ball
> > > > > Subject: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on()
> > > > >
> > > > > From: Jerry Huang <Chang-Ming.Huang@xxxxxxxxxxxxx>
> > > > >
> > > > > When f_init is zero, the SDHC can't work correctly. So f_min
> > > > > will replace f_init, when f_init is zero.
> > >
> > > What about setting f_init before your call to mmc_power_up?
> > f_init is initialized only by mmc_rescan_try_freq, and mmc_power_up
> will use it.
> > But mmc_power_up will called not only by mmc_rescan_try_freq, but also
> by other functions.
> > You will see it in my previous email about it.
> >
> 
> Yes, I know there are other callers for mmc_power_up.
> Either you set host->f_init in mmc_power_up, or you set it before you
> call mmc_power_up. I prefer the latter one but I'm not sure which one
> should be used. Maybe Chris can comment on this.
> 
First, if the f_init is initialized, mmc_power_up will use it, if not, just the f_min is used.
I think it is reasonable.


--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux