Re: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Jan 13, 2012 at 02:24:46AM +0000, Huang Changming-R66093 wrote:
> Hi, Chris,
> Could you have any comment about this patch?
> Can it go into 3.3 or 3.4?
> 
> > -----Original Message-----
> > From: Huang Changming-R66093
> > Sent: Friday, December 09, 2011 10:54 AM
> > To: linux-mmc@xxxxxxxxxxxxxxx
> > Cc: Huang Changming-R66093; Chris Ball
> > Subject: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on()
> > 
> > From: Jerry Huang <Chang-Ming.Huang@xxxxxxxxxxxxx>
> > 
> > When f_init is zero, the SDHC can't work correctly. So f_min will replace
> > f_init, when f_init is zero.

What about setting f_init before your call to mmc_power_up?

> > 
> > Signed-off-by: Jerry Huang <Chang-Ming.Huang@xxxxxxxxxxxxx>
> > CC: Chris Ball <cjb@xxxxxxxxxx>
> > ---
> > changes for v2:
> > 	- add the CC
> > changes for v3:
> > 	- enalbe the controller clock in platform, instead of core
> > 
> >  drivers/mmc/core/core.c |    5 ++++-
> >  1 files changed, 4 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> > index a08e6b1..2d40c04 100644
> > --- a/drivers/mmc/core/core.c
> > +++ b/drivers/mmc/core/core.c
> > @@ -1253,7 +1253,10 @@ static void mmc_power_up(struct mmc_host *host)
> >  	 */
> >  	mmc_delay(10);
> > 
> > -	host->ios.clock = host->f_init;
> > +	if (host->f_init)
> > +		host->ios.clock = host->f_init;
> > +	else
> > +		host->ios.clock = host->f_min;
> > 
> >  	host->ios.power_mode = MMC_POWER_ON;
> >  	mmc_set_ios(host);
> > --
> > 1.7.5.4
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux