RE: [PATCH 2/5 v2] ESDHC: set the timeout to the max value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Anton,
Could you have any comment about this serial patch?

Thanks
Jerry Huang

> -----Original Message-----
> From: Huang Changming-R66093
> Sent: Friday, January 06, 2012 1:33 PM
> To: linux-mmc@xxxxxxxxxxxxxxx
> Cc: Huang Changming-R66093; Gao Guanhua-B22826; Xie Xiaobo-R63061; Chris
> Ball
> Subject: [PATCH 2/5 v2] ESDHC: set the timeout to the max value
> 
> From: Jerry Huang <Chang-Ming.Huang@xxxxxxxxxxxxx>
> 
> When access the card on some FSL platform board (e.g p2020, p1010,
> mpc8536), the following error is reported with the timeout value
> calculated:
> 
> mmc0: Got data interrupt 0x00000020 even though no data operation was in
> progress.
> mmc0: Got data interrupt 0x00000020 even though no data operation was in
> progress.
> 
> So we skip the calculation of timeout and use the max value to fix it.
> 
> Signed-off-by: Gao Guanhua <B22826@xxxxxxxxxxxxx>
> Signed-off-by: Xie Xiaobo <X.Xie@xxxxxxxxxxxxx>
> Signed-off-by: Jerry Huang <Chang-Ming.Huang@xxxxxxxxxxxxx>
> CC: Chris Ball <cjb@xxxxxxxxxx>
> ---
> changes for v2:
> 	- change the property to compatible for quirks
> 
>  drivers/mmc/host/sdhci-pltfm.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-
> pltfm.c index ba36c36..1c254b1 100644
> --- a/drivers/mmc/host/sdhci-pltfm.c
> +++ b/drivers/mmc/host/sdhci-pltfm.c
> @@ -74,6 +74,11 @@ void sdhci_get_of_property(struct platform_device
> *pdev)
>  		if (of_device_is_compatible(np, "fsl,p2020-rev1-esdhc"))
>  			host->quirks |= SDHCI_QUIRK_BROKEN_DMA;
> 
> +		if (of_device_is_compatible(np, "fsl,p2020-esdhc")
> +			|| of_device_is_compatible(np, "fsl,p1010-esdhc")
> +			|| of_device_is_compatible(np, "fsl,mpc8536-esdhc"))
> +			host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
> +
>  		clk = of_get_property(np, "clock-frequency", &size);
>  		if (clk && size == sizeof(*clk) && *clk)
>  			pltfm_host->clock = be32_to_cpup(clk);
> --
> 1.7.5.4


--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux