Hi, On Wed, Jan 11 2012, Jaehoon Chung wrote: > Hi James, > > Thank you..:) > > Best Regards, > Jaehoon Chung > > On 01/11/2012 06:28 PM, James Hogan wrote: > >> On 09/01/12 09:41, James Hogan wrote: >>> On 01/09/2012 01:06 AM, Jaehoon Chung wrote: >>>> In FIFOTH register, can find "bit[27:16] = FIFO_DEPTH - 1". >>>> Finally, FIFO_DEPTH = bit[27:16] + 1. >>>> >>>> Now, Used the 0x7ff. but 0xfff is right. >>> >>> Nice catch. The patch itself looks okay, but I don't think the commit >>> message is very understandable, maybe something like this would be better?: >>> >>> In FIFOTH register, the RX_WMark field (bits[27:16]) defaults to >>> FIFO_DEPTH - 1. When reading it, bits[26:16] were being used, so fix it >>> to use the mask 0xfff instead of 0x7ff. >>> >>> Cheers >>> James >> >> Are you happy having your signed-off-by against this identical patch with >> a modified message Jaehoon? >> >> From: Jaehoon Chung <jh80.chung@xxxxxxxxxxx> >> >> In FIFOTH register, the RX_WMark field (bits[27:16]) defaults to >> FIFO_DEPTH - 1. When reading it, bits[26:16] were being used, so fix it >> to use the mask 0xfff instead of 0x7ff. >> >> Signed-off-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx> >> Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx> Thanks, merged to mmc-next for 3.3. - Chris. -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
