Re: mmc: dw_mmc: miscaculated the fifo-depth with wrong bit operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/09/2012 01:06 AM, Jaehoon Chung wrote:
> In FIFOTH register, can find "bit[27:16] = FIFO_DEPTH - 1".
> Finally, FIFO_DEPTH = bit[27:16] + 1.
> 
> Now, Used the 0x7ff. but 0xfff is right.

Nice catch. The patch itself looks okay, but I don't think the commit
message is very understandable, maybe something like this would be better?:

In FIFOTH register, the RX_WMark field (bits[27:16]) defaults to
FIFO_DEPTH - 1. When reading it, bits[26:16] were being used, so fix it
to use the mask 0xfff instead of 0x7ff.

Cheers
James

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux