Re: [PATCH 2/2] mmc: sdhci: Deal with failure case in sdhci_suspend_host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 28, 2011 at 02:23:32PM +0200, Adrian Hunter wrote:
> > -
> > -err_pci_suspend:
> > -	while (--i >= 0)
> > -		sdhci_resume_host(chip->slots[i]->host);
> > -	return ret;
> 
> This doesn't look right.  This is about having multiple
> host controllers on the same PCI device.  If those
> hosts have been successfully suspended, then they must
> be resumed on error.
>

You are right, I failed to understand the code.
Will send the patch again without touching the pci recover code, thanks.

> 
> >  }
> >


--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux