Re: [PATCH 1/1] mmc:Support of PCI mode for the dw_mmc driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 30, 2011 at 11:50:31PM +0530, Shashidhar Hiremath wrote:
> Hi James,
>   For some reason I was unable to reproduce the errors during compilation.
>   Can you send me one instance of the error ?

  CC [M]  drivers/mmc/host/dw_mmc.o
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_start_command’:
drivers/mmc/host/dw_mmc.c:272:2: warning: passing argument 2 of ‘dev_printk’ from incompatible pointer type [enabled by default]
include/linux/device.h:788:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_submit_data_dma’:
drivers/mmc/host/dw_mmc.c:466:2: warning: passing argument 1 of ‘dma_map_sg_attrs’ from incompatible pointer type [enabled by default]
include/asm-generic/dma-mapping-common.h:41:19: note: expected ‘struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:469:2: warning: passing argument 2 of ‘dev_printk’ from incompatible pointer type [enabled by default]
include/linux/device.h:788:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_request_end’:
drivers/mmc/host/dw_mmc.c:807:3: warning: passing argument 2 of ‘dev_printk’ from incompatible pointer type [enabled by default]
include/linux/device.h:788:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:812:3: warning: passing argument 2 of ‘dev_printk’ from incompatible pointer type [enabled by default]
include/linux/device.h:788:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_tasklet_func’:
drivers/mmc/host/dw_mmc.c:947:7: warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
include/linux/device.h:797:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_init_slot’:
drivers/mmc/host/dw_mmc.c:1654:37: warning: passing argument 2 of ‘mmc_alloc_host’ from incompatible pointer type [enabled by default]
include/linux/mmc/host.h:333:25: note: expected ‘struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_init_dma’:
drivers/mmc/host/dw_mmc.c:1761:8: warning: passing argument 1 of ‘dma_alloc_coherent’ from incompatible pointer type [enabled by default]
/home/james/src/kernel/linux/arch/x86/include/asm/dma-mapping.h:115:1: note: expected ‘struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1764:4: warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
include/linux/device.h:797:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1780:5: warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
include/linux/device.h:797:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1784:3: warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
include/linux/device.h:797:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1792:2: warning: passing argument 1 of ‘_dev_info’ from incompatible pointer type [enabled by default]
include/linux/device.h:803:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_probe’:
drivers/mmc/host/dw_mmc.c:1825:4: warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
include/linux/device.h:797:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1831:4: warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
include/linux/device.h:797:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1837:4: warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
include/linux/device.h:797:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1878:2: warning: passing argument 1 of ‘mci_wait_reset’ from incompatible pointer type [enabled by default]
drivers/mmc/host/dw_mmc.c:1797:13: note: expected ‘struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1921:24: error: ‘struct dw_mci’ has no member named ‘irq’
drivers/mmc/host/dw_mmc.c:1944:2: error: ‘pdev’ undeclared (first use in this function)
drivers/mmc/host/dw_mmc.c:1944:2: note: each undeclared identifier is reported only once for each function it appears in
drivers/mmc/host/dw_mmc.c:1961:2: error: ‘struct dw_mci’ has no member named ‘irq’
drivers/mmc/host/dw_mmc.c:1961:2: warning: passing argument 1 of ‘_dev_info’ from incompatible pointer type [enabled by default]
include/linux/device.h:803:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1966:3: warning: passing argument 1 of ‘_dev_info’ from incompatible pointer type [enabled by default]
include/linux/device.h:803:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1977:15: error: ‘struct dw_mci’ has no member named ‘irq’
drivers/mmc/host/dw_mmc.c:1986:6: warning: passing argument 1 of ‘dma_free_coherent’ from incompatible pointer type [enabled by default]
/home/james/src/kernel/linux/arch/x86/include/asm/dma-mapping.h:142:20: note: expected ‘struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_remove’:
drivers/mmc/host/dw_mmc.c:2004:3: warning: passing argument 2 of ‘dev_printk’ from incompatible pointer type [enabled by default]
include/linux/device.h:788:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:2013:15: error: ‘struct dw_mci’ has no member named ‘irq’
drivers/mmc/host/dw_mmc.c:2015:2: warning: passing argument 1 of ‘dma_free_coherent’ from incompatible pointer type [enabled by default]
/home/james/src/kernel/linux/arch/x86/include/asm/dma-mapping.h:142:20: note: expected ‘struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_resume’:
drivers/mmc/host/dw_mmc.c:2069:2: warning: passing argument 1 of ‘mci_wait_reset’ from incompatible pointer type [enabled by default]
drivers/mmc/host/dw_mmc.c:1797:13: note: expected ‘struct device *’ but argument is of type ‘struct device **’

> 
> On Wed, Nov 30, 2011 at 9:31 PM, Shashidhar Hiremath
> <shashidharh@xxxxxxxxxxxxxxx> wrote:
> > On Wed, Nov 30, 2011 at 9:11 PM, James Hogan <james.hogan@xxxxxxxxxx> wrote:
> >> Hi,
> >>
> >> On 11/30/2011 03:27 PM, Shashidhar Hiremath wrote:
> >>> Hi James,
> >>>   Sorry for the minor alignment issues.Will fix them .
> >>
> >> Thanks
> >>
> >>> I actually did
> >>> compile the code but as separate driver not along with the kernel. In
> >>> fact, I have also tested the PCI patch ,but not as separate files but
> >>> with the earlier #ifdef method  I had sent in initial patch .
> >>
> >> But the new patch was completely different, you can't just rework the
> >> entire patch and expect it to compile and work without at least trying
> >> it to make sure, as evidenced by the fact that with mmc_next + your
> >> patch, I get:
> >> dw_mmc.c: 7 errors, 22 warnings
> >> dw_mmc-pci.c: 2 errors
> >> dw_mmc-pltfm.c: 6 errors, 1 warning
> >>
> > ohh,
> > will compile and fix it
> >> Cheers
> >> James
> >>
> >>> On Wed, Nov 30, 2011 at 7:36 PM, James Hogan <james.hogan@xxxxxxxxxx> wrote:
> >>>> *sigh* You haven't actually tried compiling this have you? How do you
> >>>> know whether it works or not? You really really should at least make
> >>>> sure it compiles (for simple changes) and works without breaking
> >>>> anything (for anything non-trivial like adding support for a new bus
> >>>> like PCI)!
> >>
> >>
> >
> >
> >
> > --
> > regards,
> > Shashidhar Hiremath
> 
> 
> 
> -- 
> regards,
> Shashidhar Hiremath
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux