Re: [PATCH 1/1] mmc:Support of PCI mode for the dw_mmc driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi James,
  For some reason I was unable to reproduce the errors during compilation.
  Can you send me one instance of the error ?

On Wed, Nov 30, 2011 at 9:31 PM, Shashidhar Hiremath
<shashidharh@xxxxxxxxxxxxxxx> wrote:
> On Wed, Nov 30, 2011 at 9:11 PM, James Hogan <james.hogan@xxxxxxxxxx> wrote:
>> Hi,
>>
>> On 11/30/2011 03:27 PM, Shashidhar Hiremath wrote:
>>> Hi James,
>>>   Sorry for the minor alignment issues.Will fix them .
>>
>> Thanks
>>
>>> I actually did
>>> compile the code but as separate driver not along with the kernel. In
>>> fact, I have also tested the PCI patch ,but not as separate files but
>>> with the earlier #ifdef method  I had sent in initial patch .
>>
>> But the new patch was completely different, you can't just rework the
>> entire patch and expect it to compile and work without at least trying
>> it to make sure, as evidenced by the fact that with mmc_next + your
>> patch, I get:
>> dw_mmc.c: 7 errors, 22 warnings
>> dw_mmc-pci.c: 2 errors
>> dw_mmc-pltfm.c: 6 errors, 1 warning
>>
> ohh,
> will compile and fix it
>> Cheers
>> James
>>
>>> On Wed, Nov 30, 2011 at 7:36 PM, James Hogan <james.hogan@xxxxxxxxxx> wrote:
>>>> *sigh* You haven't actually tried compiling this have you? How do you
>>>> know whether it works or not? You really really should at least make
>>>> sure it compiles (for simple changes) and works without breaking
>>>> anything (for anything non-trivial like adding support for a new bus
>>>> like PCI)!
>>
>>
>
>
>
> --
> regards,
> Shashidhar Hiremath



-- 
regards,
Shashidhar Hiremath
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux