Hi Venkatraman, If I understand correctly, You want the test_cmds.c file to be compiled conditionally based on the menuconfig option for CONFIG_MMC_TEST right ? On Thu, Nov 17, 2011 at 4:04 PM, S, Venkatraman <svenkatr@xxxxxx> wrote: > On Wed, Nov 16, 2011 at 4:38 PM, Shashidhar Hiremath > <shashidharh@xxxxxxxxxxxxxxx> wrote: >> The patch provides An infrastructure to test commands other than Read/Write commands using the IOCTL interface.The Patch can be useful incase of validating the device to verify whether device support a given command or not. The result of the sent command will be written to the result element of the mmc_ioc_cmd structure passed through IOCTL interface. >> >> Signed-off-by: Shashidhar Hiremath <shashidharh@xxxxxxxxxxxxxxx> >> --- >> drivers/mmc/card/Makefile | 2 +- >> drivers/mmc/card/block.c | 28 ++ >> drivers/mmc/card/test_cmds.c | 743 ++++++++++++++++++++++++++++++++++++++++++ >> drivers/mmc/card/test_cmds.h | 53 +++ >> drivers/mmc/core/core.c | 4 + >> drivers/mmc/core/mmc.c | 4 + >> drivers/mmc/core/mmc_ops.c | 1 + >> drivers/mmc/core/sd.c | 2 + >> include/linux/mmc/ioctl.h | 1 + >> 9 files changed, 837 insertions(+), 1 deletions(-) >> create mode 100644 drivers/mmc/card/test_cmds.c >> create mode 100644 drivers/mmc/card/test_cmds.h >> >> diff --git a/drivers/mmc/card/Makefile b/drivers/mmc/card/Makefile >> index c73b406..ea52ee1 100644 >> --- a/drivers/mmc/card/Makefile >> +++ b/drivers/mmc/card/Makefile >> @@ -3,7 +3,7 @@ >> # >> >> obj-$(CONFIG_MMC_BLOCK) += mmc_block.o >> -mmc_block-objs := block.o queue.o >> +mmc_block-objs := block.o queue.o test_cmds.o > > Why should it be included by default ? > I think it belongs under CONFIG_MMC_TEST > >> obj-$(CONFIG_MMC_TEST) += mmc_test.o >> > -- regards, Shashidhar Hiremath -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html