On Mon, Jun 20, 2011 at 7:49 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Monday 20 June 2011, zhangfei gao wrote: >> Currently, clk_enable, clk_disable, clk_get_rate realization are >> located at arch. >> Driver/clk/clkdev.c only realize clk_get/put. >> >> I am afraid it may difficult to build the driver on other arch, like >> x86, so we may still need "depends on ARCH_MMP" for safety. > > I would recommend turning this into "depends on CLKDEV_LOOKUP" instead. > Always be specific with your dependencies so you enable the option > on all platforms that are able to build it, but not on any of the > others. > > Arnd > Select CLKDEV_LOOKUP is compile driver/clk/clkdev.c, which only provide clk_get, clk_put. Is it unsafe to assume all clk_get_rate/clk_enable/clk_disable are provided by the arch, which CLKDEV_LOOKUP? Any possibility CLKDEV_LOOKUP is selected but clk_get_rate is not realized. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
