On Mon, Jun 20, 2011 at 6:02 PM, zhangfei gao <zhangfei.gao@xxxxxxxxx> wrote: >>> >>> Why not just move the header file to include/linux/platform_data/? >>> >>> Then you can build the driver on all platforms, which improves the >>> build test coverage. >>> >>> Arnd >> >> Hi, Arnd, >> >> Thanks a lot again :) >> It is really a good suggestion, is include/linux/platform_data/ is newly added? >> Will move the header file to platform_data/pxa_sdhci.h >> arch/arm/plat-pxa/include/plat/sdhci.h => >> include/linux/platform_data/pxa_sdhci.h > > In test of build sdhci-pxav3/2 with x86_64_defconfig, link error > occurs for undefined clk_*, such as clk_enable/disable, etc. > The CLKDEV_LOOKUP is selected in arch/arm/Kconfig, but not selected in > arch/x86/Kconfig. > Any suggestion? > > Thanks > Hi Arnd Currently, clk_enable, clk_disable, clk_get_rate realization are located at arch. Driver/clk/clkdev.c only realize clk_get/put. I am afraid it may difficult to build the driver on other arch, like x86, so we may still need "depends on ARCH_MMP" for safety. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
