On Monday 20 June 2011 08:44:47 Zhangfei Gao wrote: > Without depends, MMC_SDHCI_PXAV3/2 can be chosen in other platfrom. > Build error will occur since plat/sdhci.h is located at arch/arm/plat-pxa/ > > Signed-off-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxxx> > --- > drivers/mmc/host/Kconfig | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index 198ddda..d33a3e2 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -183,6 +183,7 @@ config MMC_SDHCI_S3C > > config MMC_SDHCI_PXAV3 > tristate "Marvell MMP2 SD Host Controller support (PXAV3)" > + depends on ARCH_MMP > select MMC_SDHCI > select MMC_SDHCI_PLTFM > default CPU_MMP2 Why not just move the header file to include/linux/platform_data/? Then you can build the driver on all platforms, which improves the build test coverage. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
