Hello Shawn, > > > +#ifndef CONFIG_MMC_SDHCI_ESDHC_IMX > > > +#define cpu_is_mx25() (0) > > > +#define cpu_is_mx35() (0) > > > +#define cpu_is_mx51() (0) > > > +#define cpu_is_imx() (0) > > > +#else > > > +#define cpu_is_imx() (1) > > > +#endif > > > > ... e.g. that looks a bit frightening. > > > Agree. > > The use of cpu_is_mx..() in the driver itself seems a churn to me > even without this consolidation patch. Is it possible for us to > eliminate them by using pdata, and eventually device tree? When we > are there, I might want to revisit the consolidation again. An alternative that allows letting the logic in the driver and still getting rid of the cpu_is_ stuff is using platform ids. See drivers/spi/spi_imx.c for an example. Instead of an index into an array (as it's for the imx-spi driver) driver_data can hold flags, too, which should be enough most of the time. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
