Re: [PATCH] mmc: support sdhci-mmp2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 23 May 2011, Zhangfei Gao wrote:
>         Delete sdhci-pxa.c and replace with sdhci-mmp2.c specificlly for mmp2
> 
> Signed-off-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxxx>
> ---
>  arch/arm/plat-pxa/include/plat/sdhci.h |   43 ++++-
>  drivers/mmc/host/Kconfig               |    9 +-
>  drivers/mmc/host/Makefile              |    2 +-
>  drivers/mmc/host/sdhci-mmp2.c          |  304 ++++++++++++++++++++++++++++++++
>  drivers/mmc/host/sdhci-pxa.c           |  303 -------------------------------
>  5 files changed, 349 insertions(+), 312 deletions(-)
>  create mode 100644 drivers/mmc/host/sdhci-mmp2.c
>  delete mode 100644 drivers/mmc/host/sdhci-pxa.c

Hi Zhangfei,

You should really try to improve your changelog texts. Instead of
the one-line summary that describes what you do 'Delete sdhci-pxa.c and
replace ...', please provide a paragraph explaining why you do it,
and what the bigger plan is here.

Also, when renaming a file, please use 'git diff -M' or 'git format-patch -M'
to detect renames and generate a diff for the changes you did to the file.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux