On Monday 23 May 2011, zhangfei gao wrote: > When we start to share sdhci-pxa, we find another sdhci-platfm occurs. > While in Shawn's patch, driver self-register is recommended. > If this is new trend, it maybe a better choice to use separate driver > for each device based on updated sdhci-platfm.c by Shawn. > Will update the sdhci-mmp2.c for mmp2 only based on Shawn's modification. Having each driver register its own platform_driver sounds like the best solution to me. Whether you do that on top of sdhci-pltfm.c or model sdhci-pxa.c to be similar to sdhci-pltfm.c is a different question. I don't care much either way, so just do whichever works best for you. Maybe Shawn or Chris can recommend what they think would work better. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html