On Wed, May 11, 2011 at 10:53:37PM +0200, Antonio Ospite wrote: > OK, avoiding some duplication will be good, I agree. > I am resending a v4 with the equivalent code: > > if (host->vcc) { > int ret; > > if (power_mode == MMC_POWER_OFF) > vdd = 0; > This isn't really what I meant - what I meant was that all this logic looks like it's generic to multiple drivers. We either set a regulator or call a pdata callback to set power, both of which are completely external to the controller. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html