Hi Andrei, > -----Original Message----- > From: Andrei Warkentin [mailto:andreiw@xxxxxxxxxxxx] > Sent: Saturday, April 16, 2011 2:38 PM > To: Nath, Arindam > Cc: linux-mmc@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v3 01/12] mmc: sdhci: add support for auto CMD23 > > On Sat, Apr 16, 2011 at 12:25 AM, Nath, Arindam <Arindam.Nath@xxxxxxx> > wrote: > > Hi Andrei, > > > > I saw in one of the community threads that you also have a patch > ready for supporting Auto CMD23 for SDHCI. Can you share the same with > us? I would like to take a look at your patch first before deciding > whether it would make sense for controllers which comply with Host > Controller Spec v3.00. > > > > Will send updated patch set in a few. You and Subhash are on the Cc. > Once again, the Auto-CMD23 is completely untested. I would be > extremely grateful if you can verify it. Yes, I can do that. On that note, I have a suggestion. Since the Auto CMD23 feature is separate and none of my other patches depend on this, I would rather re-submit V3 patches except for the Auto CMD23 feature. Then once your patches have been accepted and tested, we can enable Auto CMD23 feature in the kernel. Let me know what you think. > Is there any kind of error injection mechanism you guys use to verify > the error paths for Auto 12/23? None in particular. > > By the way - > > + /* If the host can perform ADMA operation, we reset SDMA flag > */ > + if (host->flags & SDHCI_USE_ADMA) > + host->flags &= ~SDHCI_USE_SDMA; > > This seems completely unnecessary, as the code already prefers ADMA to > SDMA. What do you think? As per the Host Controller Spec v3.00, Auto CMD23 can either be used with non-DMA transfers or ADMA, but _not_ SDMA. To take care of both these cases in a single shot, I have tested against SDHCI_USE_SDMA not being set. So, I need to make sure we reset this flag when we enable ADMA support. Thanks, Arindam > > A -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
